Remove ZendTest from composer.json #4537

Closed
wants to merge 2 commits into
from

Projects

None yet

4 participants

Contributor

I have a script to deploy my application that install my application with composer, with the option --optimize-autoloader enabled. However, the dist package of ZF 2 does not include tests folder, so composer throw an exception as it tries to create the classmap from an unknown folder, which make the process fails.

The only solution is to add --prefer-source option so that the whole package with tests is loaded, but as we don't ship tests, it's better to remove this in the composer.json file.

Contributor
prolic commented May 24, 2013

unit tests are not running now.

Owner

@bakura10 I think that we have to add something to the tests/_autoload.php to autoload class files under the tests/ZendTest/ path (particularly for test assets, which PHPUnit will not autodiscover).

Contributor

@bakura10 it would be great to get your input on this composer PR: composer/composer#1857 It would fix this problem not just for zf2, but every other composer package.

Owner

@bakura10 An additional change needs to be made -- essentially, the if/then has to be removed from tests/_autoload.php, and simply promote the code in the else statement. Once that's done, we can merge the composer.json changes.

Owner

@bakura10 ping...

Contributor

Oops… done :D. Sorry for the delay :D.

Contributor

Replaced by: #4744

@bakura10 bakura10 closed this Jun 28, 2013
@bakura10 bakura10 deleted the bakura10:patch-1 branch Jun 28, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment