Update StrategyInterface.php #4539

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
2 participants
@spiffyjr

This comment has been minimized.

Show comment Hide comment
@spiffyjr

spiffyjr May 24, 2013

Contributor

You don't have to specify the optional object so this PR is not required (but for brevity may want to be merged).

Contributor

spiffyjr commented May 24, 2013

You don't have to specify the optional object so this PR is not required (but for brevity may want to be merged).

@weierophinney

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney May 24, 2013

Member

PHP considers optional arguments on an interface a part of the contract -- and thus any implementations need to define the optional argument as well, or else they will break the contract, and PHP will raise an error. As such, it is a BC break.

Just note the optional parameter as an annotation.

Member

weierophinney commented May 24, 2013

PHP considers optional arguments on an interface a part of the contract -- and thus any implementations need to define the optional argument as well, or else they will break the contract, and PHP will raise an error. As such, it is a BC break.

Just note the optional parameter as an annotation.

Kyle Spraggs added some commits May 24, 2013

@ghost ghost assigned weierophinney May 24, 2013

weierophinney added a commit that referenced this pull request May 24, 2013

Merge pull request #4539 from spiffyjr/patch-2
Update StrategyInterface.php

weierophinney added a commit that referenced this pull request May 24, 2013

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment