Fix issue with Redis Cache adapter whereby setOption was being called before connecting to Redis server #4577

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@Tomdarkness

You can't call setOption until you've connected to Redis. Not really sure why this is the case but this is how the phpredis extension behaves.

See issue #4576

@marc-mabe

This comment has been minimized.

Show comment Hide comment
@marc-mabe

marc-mabe Jun 5, 2013

Member

Thank you to find that out. The fix looks good but could you add a test please.

Member

marc-mabe commented Jun 5, 2013

Thank you to find that out. The fix looks good but could you add a test please.

@weierophinney

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney Jun 10, 2013

Owner

Ping @Tomdarkness -- would love to have this in 2.2.1, but we need a test case; can you get one to us in the next 1-2 days, please?

Owner

weierophinney commented Jun 10, 2013

Ping @Tomdarkness -- would love to have this in 2.2.1, but we need a test case; can you get one to us in the next 1-2 days, please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment