Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Ensure router factory is used by SM factory #4622

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
Owner

weierophinney commented Jun 10, 2013

As reported on the mailing list, prototypes are not being injected into the router due to the fact that Zend\Mvc\Service\RouterFactory is not using the factory() method to create a router instance. This PR accomplishes that.

@weierophinney weierophinney Ensure factory is used when creating router
- Use the `factory()` method when creating a router instance.
- Pass the `RoutePluginManager` instance to the `route_plugins` configuration
  option prior to invoking the factory.
- Extract the `route_plugins` to pass to the constructor when in the factory.

Fixes an issue whereby route prototypes were not being created.
32333f8

@DASPRiD DASPRiD was assigned Jun 10, 2013

Contributor

prolic commented Jun 11, 2013

good to merge

@DASPRiD DASPRiD closed this in 916dd0d Jun 11, 2013

@DASPRiD DASPRiD added a commit that referenced this pull request Jun 11, 2013

@DASPRiD DASPRiD Merge branch 'pull/4622' into develop
Forward port #4622
5310b89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment