Split multiple implements into multiple lines #4640

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@localheinz
Member

As it's close to calling it a day I'm issuing a no-brainer PR that does the following:

  • split implements of multiple interfaces into multiple lines (fixes #4362)
  • add use statements for interfaces in the root namespaces (related to #4363)
@weierophinney weierophinney and 1 other commented on an outdated diff Jun 12, 2013
library/Zend/Cache/Storage/Adapter/AbstractAdapter.php
@@ -24,7 +24,9 @@
use Zend\EventManager\EventManagerInterface;
use Zend\EventManager\EventsCapableInterface;
-abstract class AbstractAdapter implements StorageInterface, EventsCapableInterface
+abstract class AbstractAdapter implements
+ StorageInterface,
+ EventsCapableInterface
@weierophinney
weierophinney Jun 12, 2013 Member

These are really only necessary when the line length gets to be too long (i.e. > 100-120 characters) -- in other words, only those files that have horizontal scrolls in the files listing of this PR.

@localheinz
localheinz Jun 12, 2013 Member

In #4362 (comment) you say

You should only ever split onto multiple lines, really, when there's more than one interface, or the line is getting too long. In the latter case, the interface name goes on the next line only; the word implements stays on the previous line.

@mwillbanks mwillbanks was assigned Jun 20, 2013
@mwillbanks mwillbanks added a commit that closed this pull request Jun 20, 2013
@mwillbanks mwillbanks Merge branch 'hotfix/4640'
Close #4640
dc90e93
@mwillbanks mwillbanks added a commit that referenced this pull request Jun 20, 2013
@mwillbanks mwillbanks Merge branch 'hotfix/4640' into develop
Forward port #4640
298c0bd
@neeckeloo neeckeloo referenced this pull request Jun 21, 2013
Closed

Add use statements #4699

@localheinz localheinz deleted the localheinz:hotfix/4362 branch Oct 12, 2014
@gianarb gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' 130a50a
@gianarb gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' into develop 5c540da
@gianarb gianarb pushed a commit to zendframework/zend-server that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' 2643e17
@gianarb gianarb pushed a commit to zendframework/zend-server that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' into develop 7c69c67
@gianarb gianarb pushed a commit to zendframework/zend-ldap that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' 1ebffd3
@gianarb gianarb pushed a commit to zendframework/zend-ldap that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' into develop 35de787
@gianarb gianarb pushed a commit to zendframework/zend-session that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' 3efc3e6
@gianarb gianarb pushed a commit to zendframework/zend-session that referenced this pull request May 15, 2015
@mwillbanks mwillbanks Merge branch 'hotfix/4640' into develop 4926f18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment