Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

!IE support for conditional comments powered viewhelper #4679

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

Support for conditional comments with !IE by adding the inner wrap with comment end and start.

<!--[if IE 6]>
<p>You are using Internet Explorer 6.</p>
<![endif]-->
<!--[if !IE]><!-->
<p>You are not using Internet Explorer.</p>
<!--<![endif]-->

Member

localheinz commented Jun 18, 2013

Tests are missing, I guess.

i guess there is no need for additional tests^^

Contributor

mwillbanks commented Jun 19, 2013

@redaxmedia actually there is a need for additional tests to ensure the behavior that you had added actually works. The behavior was not there before and in the event it would be removed in the future no tests would break so it would seem like all is OK with the world.

Member

localheinz commented Jun 19, 2013

@redaxmedia actually there is a need for additional tests to ensure the behavior that you had added actually works. The behavior was not there before and in the event it would be removed in the future no tests would break so it would seem like all is OK with the world.

If this was understood as a generalization, wouldn't that mean that no tests are required ever?

Unit tests added, they are working well under zf1
(related pull request: zendframework/zf1#128)

I could not test it under zf2, because my VM Image does not have latest PHPUnit and I could not get it to update because of limited permission. Sorry for that.

@ghost ghost assigned weierophinney Jun 28, 2013

@weierophinney weierophinney added a commit that referenced this pull request Jun 28, 2013

@weierophinney weierophinney Merge pull request #4679 from redaxmedia/master
!IE support for conditional comments powered viewhelper
7f4dabc

@weierophinney weierophinney added a commit that referenced this pull request Jun 28, 2013

@weierophinney weierophinney [#4679] CS fixes
- trailing whitespace
71d97e9
Owner

weierophinney commented Jun 28, 2013

Fixed CS issues and merged to develop for release with 2.3.0.

@weierophinney weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#4679 from redaxmedia/m…
…aster

!IE support for conditional comments powered viewhelper
ee9c723

@weierophinney weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#4679] CS fixes
- trailing whitespace
b3cb310

@weierophinney weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'feature/4679' into develop d0f9e46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment