[WIP] Enforcing composer version in travis builds #4696

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants
@Ocramius
Member

Ocramius commented Jun 20, 2013

Since travis now checks out branches in detached head, this fix basically tells composer that the current branch is "dev-master"

@ghost ghost assigned mwillbanks Jun 20, 2013

@weierophinney

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney Jun 24, 2013

Member

Does this correct the issues we see on individual repos that run Travis, with regards to Composer install problems? e.g., https://travis-ci.org/weierophinney/zf2/jobs/8024153

Member

weierophinney commented Jun 24, 2013

Does this correct the issues we see on individual repos that run Travis, with regards to Composer install problems? e.g., https://travis-ci.org/weierophinney/zf2/jobs/8024153

@Ocramius

This comment has been minimized.

Show comment Hide comment
@Ocramius

Ocramius Jun 24, 2013

Member

@weierophinney yep. The only negative point is that also dev-develop is considered as master with builds, but that doesn't affect the zf2 specific builds. I still have to PR against travis too.

Member

Ocramius commented Jun 24, 2013

@weierophinney yep. The only negative point is that also dev-develop is considered as master with builds, but that doesn't affect the zf2 specific builds. I still have to PR against travis too.

@weierophinney

This comment has been minimized.

Show comment Hide comment
@weierophinney

weierophinney Jun 24, 2013

Member

@Ocramius we can have a different value on develop than on master. :)

Member

weierophinney commented Jun 24, 2013

@Ocramius we can have a different value on develop than on master. :)

@ghost ghost assigned weierophinney Jun 24, 2013

weierophinney added a commit that referenced this pull request Jun 24, 2013

Merge pull request #4696 from Ocramius/hotfix/composer-force-branch
[WIP] Enforcing composer version in travis builds

weierophinney added a commit that referenced this pull request Jun 24, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment