Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add interface `FilterEnabledInterface` #4764

Merged
merged 1 commit into from Jul 2, 2013

Conversation

Projects
None yet
3 participants
Contributor

mouhamed commented Jul 1, 2013

Add FilterEnabledInterface like StrategyEnabledInterface.
Continue discussion PR : #4752

@mouhamed mouhamed referenced this pull request Jul 1, 2013

Closed

Hydrator refactoring #4752

Coverage Status

Coverage remained the same when pulling 50c20a1 on mouhamed:hydrator-filter-enabled-interface into ecbb3dd on zendframework:develop.

@weierophinney weierophinney commented on the diff Jul 2, 2013

library/Zend/Stdlib/Hydrator/FilterEnabledInterface.php
+
+interface FilterEnabledInterface extends FilterProviderInterface
+{
+ /**
+ * Add a new filter to take care of what needs to be hydrated.
+ * To exclude e.g. the method getServiceLocator:
+ *
+ * <code>
+ * $composite->addFilter("servicelocator",
+ * function($property) {
+ * list($class, $method) = explode('::', $property);
+ * if ($method === 'getServiceLocator') {
+ * return false;
+ * }
+ * return true;
+ * }, FilterComposite::CONDITION_AND
@weierophinney

weierophinney Jul 2, 2013

Owner

move this argument to the next line, and put the first argument ("servicelocator") on a line of its own (i.e., all arguments on their own lines).

weierophinney added a commit that referenced this pull request Jul 2, 2013

weierophinney added a commit that referenced this pull request Jul 2, 2013

[#4764] CS fix
- one argument per line

weierophinney added a commit that referenced this pull request Jul 2, 2013

@weierophinney weierophinney merged commit 50c20a1 into zendframework:develop Jul 2, 2013

1 check failed

default The Travis CI build failed
Details

@ghost ghost assigned weierophinney Jul 2, 2013

@mouhamed mouhamed deleted the mouhamed:hydrator-filter-enabled-interface branch Jul 2, 2013

@mouhamed mouhamed restored the mouhamed:hydrator-filter-enabled-interface branch Jul 2, 2013

@mouhamed mouhamed deleted the mouhamed:hydrator-filter-enabled-interface branch Jul 2, 2013

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#4764 from mouhamed/hyd…
…rator-filter-enabled-interface

Add interface `FilterEnabledInterface`

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment