Change file mode from 644 to 755 templatemap_generator.php #4777

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

gag237 commented Jul 3, 2013

No description provided.

Member

Bittarman commented Jul 3, 2013

Why does the mode need changing? the general rule of thumb is that files should be 644 and directories 755

Contributor

gag237 commented Jul 3, 2013

  1. All other executable files in folder bin/ have 755
  2. Every time when I do composer {update|install} I give message: The package has modified files:
    M bin/templatemap_generator.php

diff --git a/bin/templatemap_generator.php b/bin/templatemap_generator.php
old mode 100644
new mode 100755

This changes do composer, when create links in vendor/bin, and it is true, file is executable.

Member

Maks3w commented Jul 12, 2013

It's reasonable because the PHP file has a shebang at the begin

Member

Maks3w commented Jul 12, 2013

This should be merged against master

weierophinney added a commit that referenced this pull request Jul 19, 2013

@ghost ghost assigned weierophinney Jul 19, 2013

Owner

weierophinney commented Jul 19, 2013

Cherry-picked into master and merged to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment