Adding missing "NOT IN" predicate #4781

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

sebastien-gallet commented Jul 4, 2013

Added "NOT IN" predicate.

Can be used while chaining where expressions:
->where->notIn(..., ...)

@sebastien-gallet sebastien-gallet Update Predicate.php
Added "NOT IN" predicate.
917ad7d
Contributor

ThaDafinser commented Oct 29, 2013

@sebastien-gallet first sorry for late response, but it seems that this PR was overseen.

If you want this PR still to be merged, you have to provide unittests, as this is required.

@sebastien-gallet sebastien-gallet test the "not in" predicate
provide adequate test unit for the "not in" predicate.
4157ab8
Contributor

sebastien-gallet commented Oct 29, 2013

No worries. I added the unit test. Let me know if there is anything else. Thanks.

Contributor

ThaDafinser commented Oct 29, 2013

@ralphschindler can u take a look on this?

Member

EvanDotPro commented Oct 29, 2013

👍 Looks good to me. I'll wait for @ralphschindler's stamp of approval before merging though.

Member

ralphschindler commented Nov 18, 2013

Even while small, I think this is meant for the develop branch.

@ralphschindler ralphschindler added a commit that referenced this pull request Nov 18, 2013

@ralphschindler ralphschindler PR #4781
Merge branch 'master' of git://github.com/sebastien-gallet/zf2 into sebastien-gallet-master

* 'master' of git://github.com/sebastien-gallet/zf2:
  test the "not in" predicate
  Update Predicate.php
5dfc22b

@ralphschindler ralphschindler added a commit that referenced this pull request Nov 18, 2013

@ralphschindler ralphschindler Merging PR #4781
Merge branch 'sebastien-gallet-master' into develop

* sebastien-gallet-master:
  test the "not in" predicate
  Update Predicate.php
253cfb8
Member

ralphschindler commented Nov 18, 2013

Merged to develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment