Make HTTP auth adapter's challengeClient() method public #4815

Merged
merged 6 commits into from Jul 19, 2013

Projects

None yet

4 participants

@corentin-larose
Contributor
  • changed _challengeClient() as deprecated proxy
  • pushed in the proper branch
Corentin Larose added some commits Jun 13, 2013
Corentin Larose Zend\Authentication\Adapter\Http::_challengeClient() should be public…
… since one could need to call it this way:

<code>$auth->getAdapter()->challengeClient();</code>

for instance when the authenticated user tries to access a resource for which he is not granted by ACLs.
11af8ec
Corentin Larose changed _challengeClient() as deprecated proxy 72d4c4f
Corentin Larose Coding standard fix (spaces and tabs) 681abe9
@coveralls

Coverage Status

Coverage remained the same when pulling 681abe9 on qapa:#4563 into 1166733 on zendframework:develop.

@coveralls

Coverage Status

Coverage remained the same when pulling 681abe9 on qapa:#4563 into 1166733 on zendframework:develop.

@coveralls

Coverage Status

Coverage remained the same when pulling 681abe9 on qapa:#4563 into 1166733 on zendframework:develop.

@mwillbanks
Contributor

Please add in a unit test that checks for the deprecated method to throw an error and properly returns back the correct response.

@corentin-larose
Contributor

My bad, should have done that.

Corentin Larose added some commits Jul 16, 2013
Corentin Larose Added unit test f04abb9
Corentin Larose Indentation cleanup 4c3b605
Corentin Larose Seems PHP_CodeCoverage doesn't like @covers on protected methods.
ZendTest\Authentication\Adapter\HttpTest::testProtectedMethodChallengeClientTriggersErrorDeprecated
 PHP_CodeCoverage_Exception: Trying to @cover not existing method "Adapter\Http::_challengeClient".
9fbec37
@weierophinney weierophinney added a commit that referenced this pull request Jul 19, 2013
@weierophinney weierophinney [#4815] Better error message
- Ensure the message indicate the method being invoked, and the
  fully-qualified method name of the replacement.
162d2e5
@weierophinney weierophinney added a commit that referenced this pull request Jul 19, 2013
@weierophinney weierophinney Merge branch 'feature/4815' into develop
Close #4815
d48fe42
@weierophinney weierophinney merged commit 9fbec37 into zendframework:develop Jul 19, 2013

1 check passed

default The Travis CI build passed
Details
@weierophinney weierophinney added a commit to zendframework/zend-authentication that referenced this pull request May 14, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#4815 from qapa/zendfra…
…mework/zf2#4563

Make HTTP auth adapter's challengeClient() method public
9e7b400
@weierophinney weierophinney added a commit to zendframework/zend-authentication that referenced this pull request May 14, 2015
@weierophinney weierophinney [zendframework/zendframework#4815] Better error message
- Ensure the message indicate the method being invoked, and the
  fully-qualified method name of the replacement.
dbcb148
@weierophinney weierophinney added a commit to zendframework/zend-authentication that referenced this pull request May 14, 2015
@weierophinney weierophinney Merge branch 'feature/4815' into develop 0b01291
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment