Add cas operation for apc adapter #4844

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants
@prolic
Contributor

prolic commented Jul 17, 2013

No description provided.

@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Jul 19, 2013

Member

Please add a unit test, if possible.

Member

weierophinney commented Jul 19, 2013

Please add a unit test, if possible.

@prolic

This comment has been minimized.

Show comment
Hide comment
@prolic

prolic Jul 19, 2013

Contributor

How to do that without concurrent threads?

Contributor

prolic commented Jul 19, 2013

How to do that without concurrent threads?

@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Jul 19, 2013

Member

@prolic Good point. :) Merging!

Member

weierophinney commented Jul 19, 2013

@prolic Good point. :) Merging!

weierophinney added a commit that referenced this pull request Jul 19, 2013

Merge pull request #4844 from prolic/apc_cas
Add cas operation for apc adapter

weierophinney added a commit that referenced this pull request Jul 19, 2013

@ghost ghost assigned weierophinney Jul 19, 2013

@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Jul 19, 2013

Member

Merged to develop for release with 2.3.0, as it's a feature addition.

Member

weierophinney commented Jul 19, 2013

Merged to develop for release with 2.3.0, as it's a feature addition.

@marc-mabe

This comment has been minimized.

Show comment
Hide comment
@marc-mabe

marc-mabe Dec 10, 2014

Member

This breaks the test. apc_cas allows only integer values but we allow all values :(
@Ocramius It's a bit late to revert - should I open a new issue? I'm currently not sure how to solve it.

Member

marc-mabe commented Dec 10, 2014

This breaks the test. apc_cas allows only integer values but we allow all values :(
@Ocramius It's a bit late to revert - should I open a new issue? I'm currently not sure how to solve it.

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Dec 10, 2014

Member

@marc-mabe you could open a pull request with a failing test case...

Member

Ocramius commented Dec 10, 2014

@marc-mabe you could open a pull request with a failing test case...

@marc-mabe

This comment has been minimized.

Show comment
Hide comment
@marc-mabe

marc-mabe Dec 10, 2014

Member

The test's are currently failing. Currently APC no enabled on travis - I'm working on a solution to enable more tests for travis.

https://travis-ci.org/marc-mabe/zf2/builds/43599825
WIP -> This one is using APCu as APC is not available by default on travis since PHP-5.5

Member

marc-mabe commented Dec 10, 2014

The test's are currently failing. Currently APC no enabled on travis - I'm working on a solution to enable more tests for travis.

https://travis-ci.org/marc-mabe/zf2/builds/43599825
WIP -> This one is using APCu as APC is not available by default on travis since PHP-5.5

@Ocramius

This comment has been minimized.

Show comment
Hide comment
@Ocramius

Ocramius Dec 10, 2014

Member

@marc-mabe would throwing an exception if ! is_int() be a good idea here?

Member

Ocramius commented Dec 10, 2014

@marc-mabe would throwing an exception if ! is_int() be a good idea here?

@marc-mabe

This comment has been minimized.

Show comment
Hide comment
@marc-mabe

marc-mabe Dec 10, 2014

Member

@Ocramius I don't think so because other adapter accept it and it's not possible to check before.

Member

marc-mabe commented Dec 10, 2014

@Ocramius I don't think so because other adapter accept it and it's not possible to check before.

weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-cache that referenced this pull request May 15, 2015

@prolic prolic deleted the prolic:apc_cas branch Sep 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment