Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

ArrayObject::offsetExists - Fix check on offsetExists #4852

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Contributor

mwillbanks commented Jul 18, 2013

Fix for issue #4832 where we checked isset vs. array_key_exists.

Owner

weierophinney commented Jul 18, 2013

Looks like we need to use version sniffing to determine whether to do array_key_exists or isset?

Contributor

mwillbanks commented Jul 18, 2013

negative; it's actually far worse than that... the contract in arrayobject when we turn it to references is what starts to cause the issue. i'm going to dig a bit deeper when i have some more time tomorrow :)

Owner

weierophinney commented Aug 19, 2013

@mwillbanks Any ideas on how to proceed on this? If this approach won't work, should I close this PR?

Contributor

mwillbanks commented Aug 21, 2013

@weierophinney attempted about 3 or 4 ways to resolve this. The closest I was able to get was turning the metadata into an arrayobject but that caused other tests to fail along with the request access time not to come through in the tests. I think the only real way to resolve this is to remove arrayobject completely from session.

@mwillbanks mwillbanks closed this Aug 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment