Tests for issue with unexpected injection. #4868

Closed
wants to merge 3 commits into
from

Projects

None yet

3 participants

@spalax
spalax commented Jul 22, 2013

Test for Issue #4862

@spalax
spalax commented Jul 22, 2013

"pull request" one more time, to propose it from a branch.

@weierophinney
Member

@Spalax will you be working on the fix for this as well?

@samsonasik samsonasik commented on an outdated diff Jul 23, 2013
tests/ZendTest/Di/TestAsset/AggregatedParamClass.php
@@ -0,0 +1,23 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license http://framework.zend.com/license/new-bsd New BSD License
+ * @package Zend_Di
@samsonasik samsonasik commented on an outdated diff Jul 23, 2013
...dTest/Di/TestAsset/AggregateClasses/ItemInterface.php
@@ -0,0 +1,17 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license http://framework.zend.com/license/new-bsd New BSD License
+ * @package Zend_Di
@samsonasik samsonasik commented on an outdated diff Jul 23, 2013
tests/ZendTest/Di/TestAsset/AggregateClasses/Item.php
@@ -0,0 +1,15 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license http://framework.zend.com/license/new-bsd New BSD License
+ * @package Zend_Di
@samsonasik samsonasik commented on an outdated diff Jul 23, 2013
...Test/Di/TestAsset/AggregateClasses/AggregateItems.php
@@ -0,0 +1,22 @@
+<?php
+/**
+ * Zend Framework (http://framework.zend.com/)
+ *
+ * @link http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license http://framework.zend.com/license/new-bsd New BSD License
+ * @package Zend_Di
@samsonasik

@Spalax : @package docblock should be deleted, yes, in other files at tests folder, it should be deleted too ^^

@spalax
spalax commented Jul 23, 2013

@weierophinney : yes i will work to fix it.

@spalax
spalax commented Jul 23, 2013

@samsonasik : if i remove @package docblock in all other assets inside DI, should i pul it as new one pull request ?

@samsonasik

For this PR, you should only delete what I've mentioned, make new commit and push to this branch, you can make new branch and make new PR for other specific issue :)

@spalax
spalax commented Jul 23, 2013

@samsonasik: thanks for details.

@weierophinney
Member

@Spalax Tests are looking good -- any ETA on getting a fix in place?

@spalax
spalax commented Aug 19, 2013

I do not really sure if i not broke some thing else, i passed thru tests in DI folder successfully. Please review my changes details because there is quite hard logic in method resolveMethodParameters. Would be cool to refactor DI class, or at least refactor resolveMethodParameters (300 lines of codes and a lot of nested cycles it is tough)

@weierophinney
Member

@Spalax it looks good -- your test fails before applying the change, and passes afterwards. If there is other breakage, it means the newly broken functionality was not previously tested. :)

@weierophinney weierophinney added a commit that referenced this pull request Aug 20, 2013
@weierophinney weierophinney [#4868] CS fixes
- braces
a37bbe1
@weierophinney weierophinney added a commit that referenced this pull request Aug 20, 2013
@weierophinney weierophinney Merge branch 'hotfix/4868' into develop
Forward port #4868
02daf10
@weierophinney weierophinney added a commit that closed this pull request Aug 20, 2013
@weierophinney weierophinney Merge branch 'hotfix/4868'
Close #4868
b0afbe1
@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#4868 from Spalax/test_…
…di_strange_behavior

Tests for issue with unexpected injection.
168df1d
@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney [zendframework/zendframework#4868] CS fixes
- braces
f066da4
@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/4868' fa449ae
@weierophinney weierophinney added a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/4868' into develop fe45315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment