Notices being triggered when hydrating classes with no properties with the reflection hydrator #4919

Closed
wants to merge 2 commits into
from

Conversation

Projects
None yet
2 participants
Member

Ocramius commented Jul 31, 2013

No description provided.

Member

Ocramius commented Jul 31, 2013

Anybody having an idea why the notice shown at https://travis-ci.org/Ocramius/zf2/jobs/9711636#L800 is not causing a failure?

@Ocramius Ocramius referenced this pull request in Ocramius/GeneratedHydrator Jul 31, 2013

Merged

Athletic performance tests integration #14

5 of 7 tasks complete
Member

Ocramius commented Aug 3, 2013

@weierophinney though the failure is not triggered @7fc7219, this is mergeable

@ghost ghost assigned weierophinney Aug 19, 2013

weierophinney added a commit that referenced this pull request Aug 19, 2013

Merge pull request #4919 from Ocramius/hotfix/reflection-hydrator-notice
Notices being triggered when hydrating classes with no properties with the reflection hydrator

weierophinney added a commit that referenced this pull request Aug 19, 2013

[#4919] Cleanup for consistency
- Updated docblocks to remove `@static` annotation and to align
  properties (to be consistent with rest of class).
- Return early when cached values are present, thus promoting the meat
  of the method to the method body.

weierophinney added a commit that referenced this pull request Aug 19, 2013

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#4919 from Ocramius/hot…
…fix/reflection-hydrator-notice

Notices being triggered when hydrating classes with no properties with the reflection hydrator

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

[zendframework/zendframework#4919] Cleanup for consistency
- Updated docblocks to remove `@static` annotation and to align
  properties (to be consistent with rest of class).
- Return early when cached values are present, thus promoting the meat
  of the method to the method body.

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment