Mime\Message: createFromString: really ignore unknown headers #4931

Closed
wants to merge 1 commit into
from

2 participants

@denis-sokolov

It is confusing that createFromString throws an exception that can't be ignored on such a small detail as an unknown header, especially given that unknown headers can be quite popular. For example, an X-Attachment-Id header.

It is more confusing that the exception claims to ignore the unknown header, while, of course, it's an exception.
So it doesn't ignore it.

@weierophinney weierophinney added a commit that referenced this pull request Aug 19, 2013
@weierophinney weierophinney [#4931] CS fixes
- indentation
af5beb6
@weierophinney weierophinney added a commit that referenced this pull request Aug 19, 2013
@weierophinney weierophinney Merge branch 'feature/4931' into develop
Close #4931
3914114
@weierophinney
Zend Framework member

Merged to develop for release with 2.3.0.

@basz basz added a commit that referenced this pull request Aug 27, 2013
@basz basz Merge branch 'develop' of git://github.com/zendframework/zf2
# By Matthew Weier O'Phinney (7) and others
# Via Matthew Weier O'Phinney (63) and others
* 'develop' of git://github.com/zendframework/zf2: (40 commits)
  Fix tests for php <5.4
  Find traits with TokenArrayScanner
  Added test for issue #4989
  Fixed failing tests
  Renamed interface and extract HydrationInterface
  [#4979] CS fixes
  [#4969] CS fixes
  [#4931] CS fixes
  [#4912] Re-add removed method
  CS fixes
  Revert "Revert "Merge branch 'superdweebie-rand-bugfix'""
  Fix CS
  Correction for inverted version checks
  change of version checks to use PHP_VERSION_ID constant.
  Aligned method naming to zf style
  Fixed method names
  Zend\Navigation currently uses only one text domain for translating page labels. This commit adds the new option key "textdomain" to Navigation and its (translatable) view helpers. If the option is present, it is used during translation. If the key is not present, the old behavior is applied.
  Added unit test for should not convert to array recursively if model is traversable
  PartialLoop helper: prevent convert traversable model to array recursively
  Add test
  ...
35d0648
@weierophinney weierophinney added a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#4931 from SlikNL/master
Mime\Message: createFromString: really ignore unknown headers
6d9447d
@weierophinney weierophinney added a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
@weierophinney weierophinney [zendframework/zendframework#4931] CS fixes
- indentation
edf33e1
@weierophinney weierophinney added a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'feature/4931' into develop 924558c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment