Applied trim and strtolower to Gravatar email per Gravatar docs: https://en.gravatar.com/site/implement/hash/ #4976

Merged
merged 2 commits into from Aug 18, 2013

Conversation

Projects
None yet
4 participants
Contributor

PHLAK commented Aug 16, 2013

Per the Gravatar docs, the provided email address should be trimmed of all preceding and trailing white space and converted to lowercase before being hashed. This PR adds that functionality to the ZF2 Gravatar function.

Member

Ocramius commented Aug 16, 2013

@PHLAK tests!

Member

EvanDotPro commented Aug 16, 2013

👍

@EvanDotPro EvanDotPro added a commit that referenced this pull request Aug 16, 2013

@EvanDotPro EvanDotPro Merge PHLAK:hotfix/gravatar-trim-strtolower into develop
Pull request #4976
c21cd36

@samsonasik samsonasik added a commit to samsonasik/zf2 that referenced this pull request Aug 17, 2013

@samsonasik samsonasik no new line after <?php open tag
the new line happen after PR #4976 merged
4813755
Member

Maks3w commented Aug 18, 2013

@EvanDotPro There is something wrong with the merge commits e702a42 c21cd36. This commits claims to be this PR but the code is from other PR

EvanDotPro was assigned Aug 18, 2013

@EvanDotPro EvanDotPro added a commit that referenced this pull request Aug 18, 2013

@EvanDotPro EvanDotPro Revert "Merge PHLAK:hotfix/gravatar-trim-strtolower into develop"
This reverts commit c21cd36, reversing
changes made to 3138073.

I mistakingly fetched #4967 instead of #4976.
d7d4193

@EvanDotPro EvanDotPro added a commit that referenced this pull request Aug 18, 2013

@EvanDotPro EvanDotPro Revert "Merge PHLAK:hotfix/gravatar-trim-strtolower into master"
This reverts commit e702a42, reversing
changes made to 0a74768.

I mistakingly fetched #4967 instead of #4976.
33db792

@EvanDotPro EvanDotPro added a commit that referenced this pull request Aug 18, 2013

@EvanDotPro EvanDotPro Merge PHLAK:hotfix/gravatar-trim-strtolower into master
Pull request #4976

Merge commit 'refs/pull/4976/head' of github.com:zendframework/zf2
0023a96

@EvanDotPro EvanDotPro added a commit that referenced this pull request Aug 18, 2013

@EvanDotPro EvanDotPro Merge PHLAK:hotfix/gravatar-trim-strtolower into develop
Pull request #4976
706880f

@EvanDotPro EvanDotPro merged commit 10868ae into zendframework:master Aug 18, 2013

1 check passed

default The Travis CI build passed
Details
Member

EvanDotPro commented Aug 18, 2013

@Maks3w Thanks for pointing that out. Please see my comment here. I had transposed the 6 and the 7 in the PR # when fetching locally to merge, so it merged the wrong PR.

I've reverted and corrected this now, everything should be good.

@gianarb gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015

@EvanDotPro EvanDotPro Merge PHLAK:hotfix/gravatar-trim-strtolower into develop 28be59d

@gianarb gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015

@EvanDotPro EvanDotPro Merge PHLAK:hotfix/gravatar-trim-strtolower into master
Pull request zendframework/zendframework#4976

Merge commit 'refs/pull/4976/head' of github.com:zendframework/zf2
e1a1ab3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment