[Zend-Code] Find php 5.4 traits with TokenArrayScanner #4989

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

danez commented Aug 20, 2013

Added T_TRAIT next to T_CLASS and T_INTERFACE.

For php 5.3 T_TRAIT gets defined to not get any errors.

Owner

weierophinney commented Aug 20, 2013

Please add a unit test for this as well -- and thanks!

Daniel Tschinder and others added some commits Aug 21, 2013

Find traits with TokenArrayScanner
Added T_TRAIT next to T_CLASS and T_INTERFACE.

For php 5.3 T_TRAIT gets defined to not get any errors.
Contributor

danez commented Aug 21, 2013

Added test before fixing issue

Contributor

danez commented Aug 21, 2013

composer on travis not working -> failed

Member

Thinkscape commented Aug 21, 2013

@danez Try waiting a few hours and then closing an re-opening the PR.

Contributor

danez commented Aug 21, 2013

Ok i'll try that

@danez danez closed this Aug 21, 2013

@danez danez reopened this Aug 21, 2013

@danez danez closed this Aug 21, 2013

@danez danez reopened this Aug 21, 2013

Contributor

danez commented Aug 21, 2013

Thanks for the tip.

@ghost ghost assigned weierophinney Aug 21, 2013

weierophinney added a commit that referenced this pull request Aug 21, 2013

Merge pull request #4989 from Danez/patch-1
[Zend-Code] Find php 5.4 traits with TokenArrayScanner

weierophinney added a commit that referenced this pull request Aug 21, 2013

Owner

weierophinney commented Aug 21, 2013

Merged to develop for release with 2.3.0.

@danez danez deleted the danez:patch-1 branch Aug 21, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment