Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added separator to model in renderPartial function #5080

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
4 participants

No description provided.

Owner

weierophinney commented Sep 5, 2013

Please add unit tests for this new feature.

Change to ModuleManager to accept null modules
Changed ModuleManager so I can use statements in application.config.php file like:

return array(
	'Application',
	$env=='dev' ? 'ZendDeveloperTools' : null
)

Null modules are silently ignored.

@samsonasik samsonasik commented on an outdated diff Sep 5, 2013

library/Zend/ModuleManager/ModuleManager.php
@@ -78,6 +78,7 @@ public function onLoadModules()
}
foreach ($this->getModules() as $moduleName => $module) {
+ if ($module == null) continue;
Added unit tests
Changed source to conform to Zend coding standards

@weierophinney weierophinney commented on the diff Oct 22, 2013

tests/ZendTest/ModuleManager/ModuleManagerTest.php
@@ -89,6 +89,17 @@ public function testCanLoadSomeModule()
$this->assertSame($config->some, 'thing');
}
+ public function testIgnoreNullModule()
+ {
+ $configListener = $this->defaultListeners->getConfigListener();
+ $moduleManager = new ModuleManager(array('SomeModule', null), new EventManager);
+ $moduleManager->getEventManager()->attachAggregate($this->defaultListeners);
+ $moduleManager->loadModules();
+ $loadedModules = $moduleManager->getLoadedModules();
+ $this->assertInstanceOf('SomeModule\Module', $loadedModules['SomeModule']);
+ $this->assertSame(count($loadedModules), 1);
+ }
+
@weierophinney

weierophinney Oct 22, 2013

Owner

What do the module manager commits have to do with this? Please remove.

@ghost ghost assigned weierophinney Oct 22, 2013

weierophinney added a commit that referenced this pull request Oct 22, 2013

Merge pull request #5080 from serpent7776/master
Added separator to model in renderPartial function

weierophinney added a commit that referenced this pull request Oct 22, 2013

[#5080] Revert ModuleManager changes
- outside stated scope of issue/pull request.

weierophinney added a commit that referenced this pull request Oct 22, 2013

[#5080] CS fixes
- EOF marker

weierophinney added a commit that referenced this pull request Oct 22, 2013

Owner

weierophinney commented Oct 22, 2013

Merged to develop for release with 2.3.0; removed all ModuleManager-related commits, as they were not in scope with the stated purpose of the pull request. @serpent7776 -- in the future, please create new branches per feature/bugfix, as stated in the contributing guidelines.

Member

froschdesign commented Jan 12, 2015

👎
This is not needed!

Use in your partial script:

$this->navigation()->breadcrumbs()->getSeparator();

weierophinney added a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5080 from serpent7776/…
…master

Added separator to model in renderPartial function

weierophinney added a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015

[zendframework/zendframework#5080] Revert ModuleManager changes
- outside stated scope of issue/pull request.

weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5080 from serpent7776/…
…master

Added separator to model in renderPartial function

weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment