Conversation
For people that want to help: I've spotted some test that say the test is invalid with PHP 5.4. Why? Does this means some thing can be removed in PHP 5.4? |
@bakura10 Although some have reported that iconv's //IGNORE option is broken on PHP 5.3.10 too, it seems that it's broken in PHP5.4 <= 5.4.6 (https://bugs.php.net/bug.php?id=61484). I don't know what the status on that issue is, but that might explain this test. It appears it's a glibc issue though, not sure how PHP versions affect this behaviour. (Edit: my bad, it seems that it's just iconv that doesn't accept this //IGNORE option anymore and it hasn't been fixed in PHP 5.3, but it's been removed in 5.4. I guess we need to fix that filter.) Seems like @Maks3w was the one who marked this test as incompatible (bakura10@ab87188) so he might answer you on the reasons :) |
This issue has been moved from the |
As asked by @weierophinney on IRC, I should create the PR against develop.
So let's focus for now on Filter, this is the most advanced one and mostly done (just need to find a great way for some plugin manager), and some tests were already updated.
As a reminder, the Filter refactor is mostly: