Add inline comments #5121

Merged
merged 2 commits into from Oct 20, 2013

Conversation

Projects
None yet
2 participants
Member

localheinz commented Sep 16, 2013

This PR adds two inline comments when iterating over arrays of form elements and fieldsets.

screen shot 2013-09-16 at 3 28 52 pm

library/Zend/Form/Element/Collection.php
$fieldset->populateValues($data[$name]);
unset($data[$name]);
}
}
} else {
foreach ($this->byName as $name => $element) {
+ /* @var $element ElementInterface */
@Maks3w

Maks3w Oct 2, 2013

Member

Instead add ElementInterface[] to byName property

@ghost ghost assigned Maks3w Oct 20, 2013

Maks3w added a commit that referenced this pull request Oct 20, 2013

Maks3w added a commit that referenced this pull request Oct 20, 2013

Maks3w added a commit that referenced this pull request Oct 20, 2013

@Maks3w Maks3w merged commit e246f92 into zendframework:master Oct 20, 2013

1 check passed

default The Travis CI build passed
Details

@localheinz localheinz deleted the localheinz:hotfix/inspection branch Jan 15, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment