Zend\Navigation - add to AbstractPage static factories #5136

Merged
merged 1 commit into from Oct 23, 2013

Projects

None yet

4 participants

@turrsis
Contributor
turrsis commented Sep 18, 2013

sometime use 'type' in $options not always possible

@samsonasik
Contributor

travis failed because of trailing_spaces, please fix the trailing_spaces, you can use php-cs-fixer and run :

php php-cs-fixer.phar fix /path/to/dir --fixers=trailing_spaces
@froschdesign
Member

@turrsis
Please add DocBlocks to all properties and methods.

@turrsis
Contributor
turrsis commented Sep 19, 2013

php-cs-fixer.phar is not worked on Windows :(

@samsonasik
Contributor

it is ok now 👍

@weierophinney weierophinney added a commit that referenced this pull request Oct 23, 2013
@weierophinney weierophinney Merge branch 'feature/5136' into develop
Close #5136
667cbb1
@weierophinney weierophinney merged commit 4cb8a40 into zendframework:develop Oct 23, 2013

1 check failed

default The Travis CI build failed
Details
@turrsis turrsis deleted the unknown repository branch Oct 23, 2013
@weierophinney weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#5136 from turrsis/hotf…
…ix/navigation-page-static-factory

Zend\Navigation - add to AbstractPage static factories
6bc191b
@weierophinney weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'feature/5136' into develop fc273ad
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment