Zend/Navigation/View/HelperConfig - configurable view helper #5139

Merged
merged 1 commit into from Nov 11, 2013

Projects

None yet

3 participants

@turrsis
Contributor
turrsis commented Sep 19, 2013

No description provided.

@samsonasik samsonasik commented on an outdated diff Sep 19, 2013
tests/ZendTest/View/Helper/Navigation/NavigationTest.php
/**
* Tests Zend_View_Helper_Navigation
- *
- * @category Zend
- * @package Zend_View
- * @subpackage UnitTests
- * @group Zend_View
- * @group Zend_View_Helper
@samsonasik
samsonasik Sep 19, 2013 Contributor

@group should not be removed.

@samsonasik samsonasik commented on an outdated diff Sep 20, 2013
library/Zend/View/Helper/Navigation.php
@@ -326,4 +327,19 @@ public function getPluginManager()
return $this->plugins;
}
+
+ /**
+ * Set the View object
+ *
+ * @param Renderer $view
+ * @return Navigation
@weierophinney weierophinney commented on the diff Oct 23, 2013
library/Zend/Navigation/View/HelperConfig.php
@@ -33,6 +33,12 @@ public function configureServiceManager(ServiceManager $serviceManager)
$serviceManager->setFactory('navigation', function (HelperPluginManager $pm) {
$helper = new \Zend\View\Helper\Navigation;
$helper->setServiceLocator($pm->getServiceLocator());
+
+ $config = $pm->getServiceLocator()->get('config');
+ if (isset($config['navigation_helpers'])) {
+ $config = new \Zend\ServiceManager\Config($config['navigation_helpers']);
+ $config->configureServiceManager($helper->getPluginManager());
+ }
@weierophinney
weierophinney Oct 23, 2013 Member

Please add tests for this portion of the PR.

@turrsis
turrsis Nov 7, 2013 Contributor

tests added

@weierophinney weierophinney added a commit that referenced this pull request Nov 11, 2013
@weierophinney weierophinney Merge branch 'feature/5139' into develop
Close #5139
a107799
@weierophinney weierophinney merged commit 0146c68 into zendframework:develop Nov 11, 2013

1 check failed

default The Travis CI build failed
Details
@turrsis turrsis deleted the unknown repository branch Nov 11, 2013
@weierophinney weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#5139 from turrsis/hotf…
…ix/navigation-view-helper-configurable

Zend/Navigation/View/HelperConfig - configurable view helper
7b76be0
@weierophinney weierophinney added a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'feature/5139' into develop 2e696d9
@weierophinney weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#5139 from turrsis/hotf…
…ix/navigation-view-helper-configurable

Zend/Navigation/View/HelperConfig - configurable view helper
f2863f2
@weierophinney weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'feature/5139' into develop 70909e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment