Fix for CamelCase filter when string contains multiple uppercase letters and Unicode is off #5183

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

xoob commented Sep 27, 2013

Zend\Filter\Word\CamelCaseToSeparator fails with strings containing camel case, non-word chars and multiple uppercase letters. This only happens when PCRE was compiled without Unicode support.

TheseAre_SOME_CamelCASEDWords
StringUtils::hasPcreUnicodeSupport() == true These_Are_SOME_Camel_CASED_Words
StringUtils::hasPcreUnicodeSupport() == false These_Are_SOM_E_Camel_CASED_Words

Unit test and fix attached to this PR.

+ * @link http://github.com/zendframework/zf2 for the canonical source repository
+ * @copyright Copyright (c) 2005-2013 Zend Technologies USA Inc. (http://www.zend.com)
+ * @license http://framework.zend.com/license/new-bsd New BSD License
+ * @package Zend_Filter
@samsonasik

samsonasik Oct 1, 2013

Contributor

remove @Package ^^, we should avoid new created @Package @category and @subcategory docblock

Contributor

xoob commented Oct 1, 2013

@samsonasik Removed!

@ghost ghost assigned weierophinney Oct 23, 2013

weierophinney added a commit that referenced this pull request Oct 23, 2013

Merge pull request #5183 from xoob/bugfix/camelcase
Fix for CamelCase filter when string contains multiple uppercase letters and Unicode is off

weierophinney added a commit that referenced this pull request Oct 23, 2013

weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5183 from xoob/bugfix/…
…camelcase

Fix for CamelCase filter when string contains multiple uppercase letters and Unicode is off

weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-filter that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment