[ZF3] Callback handler for PHP 5.4 #5229

Closed
wants to merge 4 commits into from

3 participants

@bakura10

As ZF3 will be PHP 5.4 only, we can optimize this class quite heavily.

All tests pass (of course Travis fails because of PHP 5.3).

@Ocramius Ocramius and 1 other commented on an outdated diff Oct 5, 2013
library/Zend/Stdlib/CallbackHandler.php
*/
- public function __construct($callback, array $metadata = array())
+ public function __construct(Callable $callback, array $metadata = array())
@Ocramius
Zend Framework member
Ocramius added a note Oct 5, 2013

callable is an internal type, not a class: should be lowercase

@bakura10
bakura10 added a note Oct 5, 2013

I think both work no? We were using "Closure" for type hint in ZF2 aren't' we?

@Ocramius
Zend Framework member
Ocramius added a note Oct 5, 2013

Closure is a class

@bakura10
bakura10 added a note Oct 5, 2013

Ok. I'll change that asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
@bakura10 bakura10 referenced this pull request Oct 5, 2013
Closed

[ZF3] Clean Stdlib #5230

@weierophinney weierophinney added this to the 3.0.0 milestone Mar 3, 2014
@Maks3w
Zend Framework member

This class has been removed on V3

@Maks3w Maks3w closed this Oct 21, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment