GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
Already on GitHub? Sign in to your account
fix for #5118
[zend/http] test get setCookie form quoted value
@ClemensSahs seems broken to me. What if a cookie contains ;?
any char in the value will be encode https://github.com/ZendFramework/zf2/blob/master/library/Zend/Http/Header/SetCookie.php#L209
Did you merge or just close?
oh ... no I delete the wrong branch in my REPO
Following the history of changes resume in #5118 (thank you to @kevinpapst) I suggest add an argument to getFieldValue for return a quoted or non quoted value
I guess last quotes are unnecessary :)
[zend/http] add a toggle property/methode for quoting the value
hm... parameter was not a bad idea but we have than a problem with toString and toStringMultipleHeaders. Both of this method call the getFieldValue and must forward the parameter. In my mind this is not practicable.
Perhaps this is a possible Solutions for both cases? Some objections? If not I write tomorrow a test for that and push it in to this PR.
Set false by default
Sorry, true for preserve the BC
Remove the default value
cast to boolean before assign the value
Return the value of the property. Due all previous feedback the value is always a boolean
@ClemensSahs add your solution and the feedback.
[zend/http] implement feedback into setcookie
[zend/http] change missing methode call
[zend/http] add test for quote and unquoting the value
I fine her if nobody have feedback we can merge this.
Merge pull request #5286 from ClemensSahs/hotfix/5118
Merge branch 'hotfix/5286' into develop
Forward port #5286
Merge pull request zendframework/zendframework#5286 from ClemensSahs/…
Merge branch 'hotfix/5286'
Forward port zendframework/zendframework#5286