Fix #5289 (abstract factories return type) #5293

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
@stefanotorresi
Contributor

stefanotorresi commented Oct 18, 2013

Fixes #5289

Just let me know if you consider allowing services to return bool(false) as a BC break, because I'm not sure.

In any case, imho it should be allowed.

@weierophinney

This comment has been minimized.

Show comment
Hide comment
@weierophinney

weierophinney Oct 18, 2013

Member

Since the original check was for a boolean false, I think we should allow any value except a null value.

Member

weierophinney commented Oct 18, 2013

Since the original check was for a boolean false, I think we should allow any value except a null value.

weierophinney added a commit that referenced this pull request Oct 23, 2013

Merge pull request #5293 from stefanotorresi/hotfix/5289
Fix #5289 (abstract factories return type)

Conflicts:
	tests/ZendTest/ServiceManager/ServiceManagerTest.php

weierophinney added a commit that referenced this pull request Oct 23, 2013

[#5293] review
- do not call initializers if we have a null value

weierophinney added a commit that referenced this pull request Oct 23, 2013

Merge branch 'hotfix/5293' into develop
Forward port #5293

Conflicts:
	library/Zend/ServiceManager/ServiceManager.php

@ghost ghost assigned weierophinney Oct 23, 2013

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5293 from stefanotorre…
…si/hotfix/5289


Fix zendframework/zendframework#5289 (abstract factories return type)

Conflicts:
	tests/ZendTest/ServiceManager/ServiceManagerTest.php

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

[zendframework/zendframework#5293] review
- do not call initializers if we have a null value

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

Merge branch 'hotfix/5293' into develop
Forward port zendframework/zendframework#5293

Conflicts:
	library/Zend/ServiceManager/ServiceManager.php
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment