change self:: with static:: in call-ing static property/method #5329

Merged
merged 1 commit into from Oct 23, 2013

Conversation

Projects
None yet
2 participants
Contributor

samsonasik commented Oct 23, 2013

some of this change is part of #5136 that I forgot to comment about changing self:: to static:: when calling static property/method that merged to develop branch. So I proposed it to be pointed to develop

Contributor

samsonasik commented Oct 23, 2013

travis failure is not related to this PR.

@@ -78,11 +78,11 @@ public static function compareVersion($version)
*/
public static function getLatest($service = self::VERSION_SERVICE_ZEND, Http\Client $httpClient = null)
{
- if (null !== self::$latestVersion) {
@weierophinney

weierophinney Oct 23, 2013

Owner

Since this class is marked as final, changing self to static makes no sense. :) (I'll revert these on merge.)

weierophinney added a commit that referenced this pull request Oct 23, 2013

Merge pull request #5329 from samsonasik/fix/self-to-static
change self:: with static:: in call-ing static property/method

weierophinney added a commit that referenced this pull request Oct 23, 2013

[#5329] Revert changes to Zend\Version
- Since the class is final, LSB can never be invoked.

weierophinney added a commit that referenced this pull request Oct 23, 2013

@weierophinney weierophinney merged commit ab9583a into zendframework:develop Oct 23, 2013

1 check failed

default The Travis CI build failed
Details

@ghost ghost assigned weierophinney Oct 23, 2013

weierophinney added a commit to zendframework/zend-mail that referenced this pull request May 14, 2015

Merge pull request zendframework/zendframework#5329 from samsonasik/f…
…ix/self-to-static

change self:: with static:: in call-ing static property/method

weierophinney added a commit to zendframework/zend-mail that referenced this pull request May 14, 2015

weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5329 from samsonasik/f…
…ix/self-to-static

change self:: with static:: in call-ing static property/method

weierophinney added a commit to zendframework/zend-navigation that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment