Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add regression test for #5237 #5390

Merged
merged 2 commits into from Nov 1, 2013

Conversation

Projects
None yet
2 participants
Contributor

stefanotorresi commented Oct 31, 2013

This PR adds a test for a bug in ServiceManager::canCreateServiceWithName() that #4285 was supposed to fix but was actually fixed by #5237.

@weierophinney
any chance to include both this and #5237 in 2.2.5? The bug is quite a nasty one.

Owner

weierophinney commented Nov 1, 2013

@stefanotorresi too late for 2.2.5, as that was already tagged by the time this came in.

Owner

weierophinney commented Nov 1, 2013

@stefanotorresi Also, #5237 was against develop, and rightfully so as it had some internal changes in behavior. This will have to be for 2.3.0.

@weierophinney weierophinney added a commit that referenced this pull request Nov 1, 2013

@weierophinney weierophinney Merge pull request #5390 from stefanotorresi/test/abstract-factories
Add regression test for #5237
33a31b2

@weierophinney weierophinney added a commit that referenced this pull request Nov 1, 2013

@weierophinney weierophinney Merge branch 'feature/5390' into develop
Close #5390
cad32c9

@weierophinney weierophinney merged commit d9329c0 into zendframework:develop Nov 1, 2013

1 check failed

default The Travis CI build failed
Details

@weierophinney weierophinney was assigned Nov 1, 2013

@stefanotorresi stefanotorresi deleted the stefanotorresi:test/abstract-factories branch Nov 4, 2013

@weierophinney weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#5390 from stefanotorre…
…si/test/abstract-factories

Add regression test for zendframework/zendframework#5237
96aab3d

@weierophinney weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'feature/5390' into develop c4c2224
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment