The fixes done during #5245 merge had to be, well... fixed! :p
Revert "[#5245] CS fixes"
This reverts commit 76074d4.
ha! if cs fix is applied to the test classes (which is what this PR does), the tests fail because the fixer alters the argument of the assertions.
i'll wait for comments.
some reflection tests have to be escluded from cs fixing otherwise
assertions arguments will be affected.
When I run php-cs-fixer after these changes, it still highlights FunctionReflectionTest.php, MethodReflectionTest.php, and TestAsset/closures.php. The tests still run after updating those, however. Shall I go ahead and apply those changes and finish the merge?
Hmm that's odd. Have you tried running it via check-cs.sh ?
@stefanotorresi Yes, of course. And those are the files it highlights -- tailing spaces and function_declaration errors on the first 2, and braces and function_declaration errors on the last.
@stefanotorresi actually... I have a script that goes and runs php-cs-fixer on any files that have changed from the branch I merged against. Evidently, php-cs-fixer does not consult the .php_cs file when you do that, or ignores it when the argument is a file and not a directory. We're good to go here.
Merge branch 'hotfix/5391' into develop
ok then :)
for the record, it is exactly as you said: php-cs-fixer only evaluates .php_cs if it's contained in the directory passed as an argument, so running it on single files or subdirectories won't work.