Fix typehint for getServiceLocator(). #5471

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
2 participants
Member

Thinkscape commented Nov 13, 2013

It's always ServiceLocatorInterface because:

  • getServiceLocator() returns the contents of $this->serviceLocator
  • which is set by setServiceLocator(ServiceLocatorInterface $sl).
  • setter has a specific type hint
Fix typehint for getServiceLocator().
It's always `ServiceLocatorInterface` because getServiceLocator() returns the contents of $this->serviceLocator which is set by setServiceLocator(ServiceLocatorInterface $sl).

weierophinney added a commit that referenced this pull request Nov 13, 2013

Merge pull request #5471 from Thinkscape/patch-1
Fix typehint for getServiceLocator().

weierophinney added a commit that referenced this pull request Nov 13, 2013

@ghost ghost assigned weierophinney Nov 13, 2013

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5471 from Thinkscape/p…
…atch-1

Fix typehint for getServiceLocator().

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment