remove unused use statements #5472

Merged
merged 3 commits into from Nov 18, 2013

Projects

None yet

4 participants

@samsonasik
Contributor

I just realized that php-cs-fixer support removing unused use statement ^^

@samsonasik samsonasik remove unused uses
using php-cs-fixer
97b5332
@weierophinney
Member

@samsonasik There are test failures in all PHP versions at this point; it looks like the script removed code from the Zend\Code test suite that was necessary.

@samsonasik
Contributor

@weierophinney fixed ;)

@Maks3w
Member
Maks3w commented Nov 14, 2013

@samsonasik Please add the necessary changes to the Travis script for automatize this.

https://github.com/zendframework/zf2/blob/master/bin/check-cs.sh

@samsonasik
Contributor

@Maks3w done, I have updated bin/check-cs.sh , and I added exclude tests/ZendTest/Code at tests/.php_cs for checking because of some use statements are necessary as @weierophinney said.

@samsonasik
Contributor

btw, I curious when adding exclude tests/ZendTest/Code at tests/.php_cs is causing ZendTest/Code is not tested anymore for other case ( trailing_space, function_declaration, etc), I will test it to add failure test on it.

@samsonasik
Contributor

@weierophinney @Maks3w I have tested excluding tests/ZendTest/Code at tests/.php_cs but it cause that folder not tested anymore for other cases ( trailing_spaces, etc). So, I propose to only check --fixers=unused_use only for library folder, how ?

@DASPRiD
Member
DASPRiD commented Nov 15, 2013

IDEs also make use of the use statements in doc blocks. Make sure that the removed aliases were not used in these.

@samsonasik
Contributor

@DASPRiD I already check that, all aliases for unused use is not used at docblock. Let me know if I missed something, thanks.

@Maks3w
Member
Maks3w commented Nov 15, 2013

I'll review this manually sortly.

@Maks3w Maks3w was assigned Nov 15, 2013
@Maks3w Maks3w merged commit 2d984f2 into zendframework:master Nov 18, 2013

1 check passed

default The Travis CI build passed
Details
@samsonasik samsonasik deleted the samsonasik:rem.unused.use branch Nov 18, 2013
@weierophinney weierophinney pushed a commit to zendframework/zend-mail that referenced this pull request May 14, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 2fabbbb
@weierophinney weierophinney pushed a commit to zendframework/zend-mail that referenced this pull request May 14, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop d35196b
@weierophinney weierophinney pushed a commit to zendframework/zend-mail that referenced this pull request May 14, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 402b003
@gianarb gianarb pushed a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 06100ad
@gianarb gianarb pushed a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop a2237d5
@gianarb gianarb pushed a commit to zendframework/zend-servicemanager that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master a464957
@gianarb gianarb pushed a commit to zendframework/zend-math that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 d465269
@gianarb gianarb pushed a commit to zendframework/zend-math that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 4d54e0b
@gianarb gianarb pushed a commit to zendframework/zend-math that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master bc98187
@gianarb gianarb pushed a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 93a6b85
@gianarb gianarb pushed a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 27c896d
@gianarb gianarb pushed a commit to zendframework/zend-modulemanager that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master c2e87c3
@gianarb gianarb pushed a commit to zendframework/zend-config that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 15e36b9
@gianarb gianarb pushed a commit to zendframework/zend-config that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 19fe71c
@gianarb gianarb pushed a commit to zendframework/zend-config that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master a4efcfe
@gianarb gianarb pushed a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 7be5463
@gianarb gianarb pushed a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 7ec8299
@gianarb gianarb pushed a commit to zendframework/zend-stdlib that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 9c877e4
@gianarb gianarb pushed a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 fcc4215
@gianarb gianarb pushed a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 465be89
@gianarb gianarb pushed a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master f40e1d4
@gianarb gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 ee7d929
@gianarb gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 66d9209
@gianarb gianarb pushed a commit to zendframework/zend-paginator that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master e07a576
@gianarb gianarb pushed a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 acad39e
@gianarb gianarb pushed a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 7aa5eb4
@gianarb gianarb pushed a commit to zendframework/zend-i18n that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master c99b627
@gianarb gianarb pushed a commit to zendframework/zend-text that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 72dc4a1
@gianarb gianarb pushed a commit to zendframework/zend-text that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 8109dd0
@gianarb gianarb pushed a commit to zendframework/zend-text that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 028a639
@gianarb gianarb pushed a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 f5a2f78
@gianarb gianarb pushed a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop f2ee090
@gianarb gianarb pushed a commit to zendframework/zend-inputfilter that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master b904b9d
@gianarb gianarb pushed a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 27a62f0
@gianarb gianarb pushed a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop 454db1e
@gianarb gianarb pushed a commit to zendframework/zend-di that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master ddebf4d
@gianarb gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 896d830
@gianarb gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop fc99eb3
@gianarb gianarb pushed a commit to zendframework/zend-http that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 75434aa
@gianarb gianarb pushed a commit to zendframework/zend-progressbar that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 35d7020
@gianarb gianarb pushed a commit to zendframework/zend-progressbar that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop d79823d
@gianarb gianarb pushed a commit to zendframework/zend-progressbar that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 16d6965
@gianarb gianarb pushed a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 154595d
@gianarb gianarb pushed a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop c5ec0fa
@gianarb gianarb pushed a commit to zendframework/zend-filter that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 691454a
@gianarb gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 6e8a186
@gianarb gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop a8af3df
@gianarb gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 5084e3b
@gianarb gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 c2161a6
@gianarb gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop c99dfc2
@gianarb gianarb pushed a commit to zendframework/zend-cache that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 756d5d5
@gianarb gianarb pushed a commit to zendframework/zend-soap that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 8d8c832
@gianarb gianarb pushed a commit to zendframework/zend-soap that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop b6d661c
@gianarb gianarb pushed a commit to zendframework/zend-soap that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master 52f7747
@gianarb gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 ce66c6d
@gianarb gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in develop a0d4f17
@gianarb gianarb pushed a commit to zendframework/zend-view that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5472 in master d9d9b78
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment