Specify correct return type for `Pdo\Connection::getLastGeneratedValue` #5508

Closed
wants to merge 1 commit into
from

Projects

None yet

2 participants

@irnc
Contributor
irnc commented Nov 20, 2013

See http://php.net/manual/en/pdo.lastinsertid.php for reference that it returns sting instead of int.

TODO: change type of $lastInsertValue property and getLastInsertValue method in Zend/Db/TableGateway/AbstractTableGateway.php accordingly.

@irnc irnc Specify correct return type for `Pdo\Connection::getLastGeneratedValue`
See http://php.net/manual/en/pdo.lastinsertid.php for reference that it returns `sting` instead of `int`.

TODO: change type of `$lastInsertValue` property and `getLastInsertValue` method in `Zend/Db/TableGateway/AbstractTableGateway.php` accordingly.
a41c9e4
@ralphschindler
Member

Is this PR a WIP, or ready to go?

@ralphschindler ralphschindler added the Db label Feb 27, 2014
@ralphschindler ralphschindler self-assigned this Feb 27, 2014
@ralphschindler ralphschindler added this to the 2.2.6 milestone Feb 27, 2014
@ralphschindler ralphschindler added a commit that closed this pull request Feb 28, 2014
@ralphschindler ralphschindler Closes #5508
Merge branch 'hotfix/5508'

* hotfix/5508:
  Specify correct return type for `Pdo\Connection::getLastGeneratedValue`
026e47b
@ralphschindler ralphschindler added a commit that referenced this pull request Feb 28, 2014
@ralphschindler ralphschindler Forward #5508
Merge branch 'hotfix/5508' into develop

* hotfix/5508:
  Specify correct return type for `Pdo\Connection::getLastGeneratedValue`
4917c99
@irnc irnc deleted the unknown repository branch May 24, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment