Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Add driver options to the Oci8 Db adapter #5552

Merged
merged 1 commit into from Dec 3, 2013

Conversation

Projects
None yet
2 participants
Contributor

pceric commented Nov 28, 2013

For some reason the driver options support is missing from the Oci8 driver rendering it unusable for our Oracle setup. This simple patch adds support for those options into Zend\Db.

@ralphschindler ralphschindler commented on the diff Dec 3, 2013

library/Zend/Db/Adapter/Driver/Oci8/Connection.php
@@ -184,17 +184,18 @@ public function connect()
$password = $findParameterValue(array('password'));
$connectionString = $findParameterValue(array('connection_string', 'connectionstring', 'connection', 'hostname', 'instance'));
$characterSet = $findParameterValue(array('character_set', 'charset', 'encoding'));
+ $sessionMode = $findParameterValue(array('session_mode', 'driver_options'));
@ralphschindler

ralphschindler Dec 3, 2013

Member

driver_options would generally be an array in other contexts, I am going to remove this and just stick with session_mode. Thanks!

@ralphschindler ralphschindler added a commit that referenced this pull request Dec 3, 2013

@ralphschindler ralphschindler Merging PR #5552
Merge branch 'master' of git://github.com/pceric/zf2 into pceric-master

* 'master' of git://github.com/pceric/zf2:
  Add driver options to the Oci8 Db adapter
e4d6dec

@ralphschindler ralphschindler added a commit that referenced this pull request Dec 3, 2013

@ralphschindler ralphschindler Merging PR #5552
Merge branch 'pceric-master'

* pceric-master:
  Removed 'driver_options' from oci8 connection class parameters
  Add driver options to the Oci8 Db adapter
fe2a0cb

@ralphschindler ralphschindler merged commit b5d9a29 into zendframework:master Dec 3, 2013

1 check failed

default The Travis CI build failed
Details

@ralphschindler ralphschindler added a commit that referenced this pull request Dec 3, 2013

@ralphschindler ralphschindler Forward #5552
Merge branch 'pceric-master' into develop

* pceric-master:
  Removed 'driver_options' from oci8 connection class parameters
  Add driver options to the Oci8 Db adapter
148a88a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment