Fixes #4670 #5567

merged 3 commits into from Feb 15, 2014


None yet

3 participants

@Maks3w Maks3w commented on the diff Dec 2, 2013
@@ -649,7 +649,12 @@ public function removeMethod($methodName)
public function hasMethod($methodName)
- return isset($this->methods[$methodName]);
Maks3w Dec 2, 2013

Instead normalize the array key at the moment of set the value.

Maks3w Dec 3, 2013

here write return isset($this->methods[strtolower($methodName)]);

and change line 603 adding a strtolower to the key var.
Replace 596 with a call to hasMethod

Refactor getMethod and removeMethod removing the loops

Maks3w Dec 3, 2013

As you see fixing the issue here only change the visible problem but don't fix the source of the problem.


@Maks3w done ;), please let me know if I missed something. thanks.


What is the status of this?

@Maks3w Maks3w was assigned Feb 15, 2014
@Maks3w Maks3w merged commit a7e9391 into zendframework:master Feb 15, 2014

1 check passed

Details default The Travis CI build passed
@samsonasik samsonasik deleted the samsonasik:fix/codehasmethod branch Mar 8, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment