More lenient db detection in Logger abstract factory #5588

Merged
merged 1 commit into from Dec 5, 2013

Conversation

Projects
None yet
2 participants
Owner

weierophinney commented Dec 5, 2013

The fix for #5254 was too strict in that it checked for a very specific writer name, when it should only be checking the "db" options key. This PR modifies the behavior of the logger abstract factory to do that.

@weierophinney weierophinney Improvement to #5254
- Do not check on the writer name, only the presence, type, and
  availability of the "db" option value.

  See #5254 (comment)
d0d6a79

@ralphschindler ralphschindler added a commit that referenced this pull request Dec 5, 2013

@ralphschindler ralphschindler Merging PR #5588
Merge branch 'weierophinney-hotfix/5254-improvement'

* weierophinney-hotfix/5254-improvement:
  Improvement to #5254
55d43c9

@ralphschindler ralphschindler merged commit d0d6a79 into zendframework:master Dec 5, 2013

1 check failed

default The Travis CI build failed
Details

@ralphschindler ralphschindler added a commit that referenced this pull request Dec 5, 2013

@ralphschindler ralphschindler Foward PR #5588
Merge branch 'weierophinney-hotfix/5254-improvement' into develop

* weierophinney-hotfix/5254-improvement:
  Improvement to #5254
88480e7

weierophinney deleted the weierophinney:hotfix/5254-improvement branch Dec 5, 2013

@gianarb gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015

@ralphschindler ralphschindler Merging PR zendframework/zendframework#5588
Merge branch 'weierophinney-hotfix/5254-improvement'

* weierophinney-hotfix/5254-improvement:
  Improvement to zendframework/zendframework#5254
df3a849

@gianarb gianarb pushed a commit to zendframework/zend-log that referenced this pull request May 15, 2015

@ralphschindler ralphschindler Foward PR zendframework/zendframework#5588
Merge branch 'weierophinney-hotfix/5254-improvement' into develop

* weierophinney-hotfix/5254-improvement:
  Improvement to zendframework/zendframework#5254
d91945a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment