SetCookie With expiry of over 2038 fail on 32bit systems #5677

Closed
wants to merge 4 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

mbn18 commented Jan 4, 2014

Title say it all. Bug 2038

Change this to a negative comparison and call $this->markTestAsIncomplete('this test is skipped because ....');

Sorry. The correct method is markTestSkipped

Looks that all this block can be merged with the previous if.

Contributor

mbn18 commented Jan 6, 2014

@Maks3w ok its up. Do you have merge rights?

Contributor

mbn18 commented Feb 26, 2014

@Maks3w , hi, can you authorize this?

Member

Maks3w commented Feb 26, 2014

I have doubts between throw exception or your proposal of silent change. @weierophinney thoughts?

@Maks3w Maks3w added this to the 2.2.6 milestone Feb 26, 2014

Owner

weierophinney commented Mar 3, 2014

I'm fine with the proposed silent change. Developers will expect this to "just do the right thing".

@ralphschindler ralphschindler self-assigned this Mar 3, 2014

weierophinney added a commit that referenced this pull request Mar 4, 2014

Merge pull request #5677 from mbn18/master
SetCookie With expiry of over 2038 fail on 32bit systems

weierophinney added a commit that referenced this pull request Mar 4, 2014

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5677 from mbn18/master
SetCookie With expiry of over 2038 fail on 32bit systems

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment