Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Implemented writeTextBlock method in Zend\Console\Adapter\AbstractAdapter #5711

Merged
merged 6 commits into from Mar 4, 2014

Conversation

Projects
None yet
3 participants
Contributor

nicktacular commented Jan 12, 2014

I noticed that the Zend\Console\Adapter\AbstractAdapter::writeTextBlock() method was not implemented, so I implemented it, added tests, and ran php-cs-fixer.

Also, in order to be able to verify how this method writes data, I added an array to the test asset class ConsoleAdapter. Without this tracking array, the output buffering doesn't correctly show which data I expect since there isn't a way to track text in between calls to AbstractAdapter::setPos().

@Maks3w Maks3w commented on an outdated diff Feb 23, 2014

library/Zend/Console/Adapter/AbstractAdapter.php
@@ -108,16 +108,16 @@ public function writeAt($text, $x, $y, $color = null, $bgColor = null)
* If X or Y coordinate value is negative, it will be calculated as the distance from far right or bottom edge
* of the console (respectively).
*
- * @param int $x1 Top-left corner X coordinate (column)
@Maks3w

Maks3w Feb 23, 2014

Member

Please roll back every change not related with the fix

Contributor

nicktacular commented Feb 28, 2014

Stylistic changes reverted.

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 3, 2014

@weierophinney weierophinney self-assigned this Mar 4, 2014

@weierophinney weierophinney added a commit that referenced this pull request Mar 4, 2014

@weierophinney weierophinney Merge pull request #5711 from nicktacular/console
Implemented writeTextBlock method in Zend\Console\Adapter\AbstractAdapter
0e2e75c

@weierophinney weierophinney added a commit that referenced this pull request Mar 4, 2014

@weierophinney weierophinney [#5711] CS fixes
- space after opening comment
- removed a conditional by rephrasing and returning in the conditional
  body
a8bcd94

@weierophinney weierophinney added a commit that referenced this pull request Mar 4, 2014

@weierophinney weierophinney Merge branch 'feature/5711' into develop
Close #5711
8719e93

@weierophinney weierophinney merged commit 1124958 into zendframework:develop Mar 4, 2014

1 check failed

default The Travis CI build could not complete due to an error
Details

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#5711 from nicktacular/…
…console

Implemented writeTextBlock method in Zend\Console\Adapter\AbstractAdapter
c420065

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney [zendframework/zendframework#5711] CS fixes
- space after opening comment
- removed a conditional by rephrasing and returning in the conditional
  body
4c59281

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'feature/5711' into develop e1fb28e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment