Support PHPUnit 3.8+ compatibility #5781

Merged
merged 2 commits into from Feb 7, 2014

Conversation

Projects
None yet
3 participants
Contributor

JoelMarcey commented Feb 4, 2014

PHPUnit 3.8+ adds a method to its PHPUnit_Framework_TestListener interface called addRiskyTest(). Need to stub it out to avoid "must implement this interface method" fatals when using 3.8+.

Support PHPUnit 3.8+ compatibility
PHPUnit 3.8+ adds a method to its PHPUnit_Framework_TestListener interface called addRiskyTest(). Need to stub it out to avoid "must implement this interface method" fatals when using 3.8+.
Member

Maks3w commented Feb 4, 2014

Please remove the trailing spaces

Contributor

JoelMarcey commented Feb 4, 2014

I am sorry -- what trailing spaces?

tests/ZendTest/Db/IntegrationTestListener.php
@@ -107,7 +107,8 @@ public function addIncompleteTest(PHPUnit_Framework_Test $test, Exception $e, $t
public function addSkippedTest(PHPUnit_Framework_Test $test, Exception $e, $time) {}
public function startTestSuite(PHPUnit_Framework_TestSuite $suite) {}
public function endTestSuite(PHPUnit_Framework_TestSuite $suite) {}
-
+ public function addRiskyTest(PHPUnit_Framework_Test $test, Exception $e, $time) {} // Support PHPUnit 3.8+
+
Contributor

JoelMarcey commented Feb 5, 2014

I believe I fixed this with c29404d

Contributor

JoelMarcey commented Feb 7, 2014

friendly ping -- how often do pull requests get merged, out of curiosity?

Member

Ocramius commented Feb 7, 2014

@JoelMarcey AFAIK, everyone conferencing right now.

Contributor

JoelMarcey commented Feb 7, 2014

@Ocramius Ahh. Thanks. I am just looking forward to removing using my fork and using the official branch in our test runner :)

@ghost ghost assigned Maks3w Feb 7, 2014

Maks3w added a commit that referenced this pull request Feb 7, 2014

Maks3w added a commit that referenced this pull request Feb 7, 2014

Maks3w added a commit that referenced this pull request Feb 7, 2014

@Maks3w Maks3w merged commit c29404d into zendframework:master Feb 7, 2014

1 check passed

default The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment