Fixes #4926 #5831

Closed
wants to merge 2 commits into
from

Projects

None yet

3 participants

@samsonasik
Contributor

Fixes #4926

@Maks3w Maks3w commented on the diff Feb 15, 2014
library/Zend/Db/Sql/Insert.php
@@ -91,7 +91,7 @@ public function columns(array $columns)
*/
public function values(array $values, $flag = self::VALUES_SET)
{
- if ($values == null) {
@Maks3w
Maks3w Feb 15, 2014 Member

I think that the problem was not use a strict comparison ===

@Maks3w Maks3w was assigned Feb 15, 2014
@samsonasik samsonasik closed this Feb 15, 2014
@kkamkou

Does this check/message make any sense here?

Contributor

yes, so, we can do

$table->insert(array());

see issue #4926

Problem was in typecasting and not in the validation. lines 94-96 are useless.

Contributor

I think you better create PR if you have better suggestion, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment