Avoid function usage in loops #5833

Merged
merged 1 commit into from Feb 18, 2014

Projects

None yet

4 participants

@neeckeloo
Contributor

Complete the previous pull request #5815.

@samsonasik
Contributor

I think it doesn't make sense, see http://3v4l.org/Iu9gv#v500 and PR that I've created before #4923 that closed :p

@neeckeloo
Contributor

I'm not sure that we speak exactly the same thing. Currently, in these cases, the number of items is calculated in each iteration. This could simply be done once before the execution of the loop and therefore improve performance.

@samsonasik
Contributor

ok ;)

@bakura10
Contributor

+1, can be merged!

@Maks3w Maks3w was assigned Feb 18, 2014
@Maks3w Maks3w merged commit c62fdae into zendframework:master Feb 18, 2014

1 check passed

default The Travis CI build passed
Details
@neeckeloo neeckeloo deleted the unknown repository branch Feb 18, 2014
@gianarb gianarb pushed a commit to zendframework/zend-ldap that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5833 dcb7dfd
@gianarb gianarb pushed a commit to zendframework/zend-ldap that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5833 in develop f327178
@gianarb gianarb pushed a commit to zendframework/zend-ldap that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5833 in master b1139ea
@gianarb gianarb pushed a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5833 61a991c
@gianarb gianarb pushed a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5833 in develop a952daa
@gianarb gianarb pushed a commit to zendframework/zend-mime that referenced this pull request May 15, 2015
@Maks3w Maks3w Merge pull request zendframework/zendframework#5833 in master 6d333fa
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment