Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Removed Zend\Http\Client\Cookies #5840

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Owner

ezimuel commented Feb 18, 2014

The Zend\Http\Client\Cookies is a misprint from ZF. The correct component is Zend\Http\Cookies. I removed it and fixed the unit test.

@weierophinney weierophinney added this to the 2.3.0 milestone Feb 18, 2014

@weierophinney weierophinney self-assigned this Feb 18, 2014

Member

Ocramius commented Feb 18, 2014

@ezimuel shouldn't you extend from the correct class and leave this one for BC compat?

Owner

ezimuel commented Feb 18, 2014

@Ocramius This class is not used in the framework, and makes no sense to use it.

Member

Ocramius commented Feb 18, 2014

@ezimuel alright

@ezimuel ezimuel referenced this pull request in zendframework/zf2-documentation Feb 18, 2014

Merged

Removed the reference to Zend\Http\Client\Cookies #1197

Member

Maks3w commented Feb 18, 2014

I think we need to declare it first as deprecated and then remove it in 2.3.0 and best if 2.4.0

Owner

weierophinney commented Feb 20, 2014

I think we need to declare it first as deprecated

I disagree. The reason @ezimuel created this PR is because of people indicating confusion over which one to use. Only one is correct in this particular case; the other, which is removed in this PR, cannot be used with the HTTP client in its current incarnation.

weierophinney added a commit that referenced this pull request Feb 20, 2014

Merge pull request #5840 from ezimuel/fix/cookies
Removed Zend\Http\Client\Cookies

Conflicts:
	library/Zend/Http/Client/Cookies.php

weierophinney added a commit that referenced this pull request Feb 20, 2014

weierophinney added a commit that referenced this pull request Feb 20, 2014

Owner

weierophinney commented Feb 20, 2014

Merged to develop for release with 2.3.0.

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5840 from ezimuel/fix/…
…cookies

Removed Zend\Http\Client\Cookies

Conflicts:
	library/Zend/Http/Client/Cookies.php

weierophinney added a commit to zendframework/zend-http that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment