Fixes #4943 #5853

Closed
wants to merge 3 commits into
from

Conversation

Projects
None yet
3 participants
Contributor

samsonasik commented Feb 21, 2014

Fixes #4943

@ralphschindler ralphschindler added the Db label Feb 27, 2014

@ralphschindler ralphschindler added this to the 2.2.6 milestone Feb 27, 2014

@ralphschindler ralphschindler self-assigned this Feb 27, 2014

Member

ralphschindler commented Feb 28, 2014

Is this ready or a WIP?

Contributor

samsonasik commented Feb 28, 2014

I'm done. but let me know if any suggestion / revision ;). Thanks.

Member

ralphschindler commented Feb 28, 2014

I ask b/c there are a couple of new skipped tests.

Contributor

samsonasik commented Feb 28, 2014

As I said at #4943 , I'm stuck on mocking test, if any suggestion to make it work without skipped test, let me know ;)

@weierophinney weierophinney modified the milestones: 2.3.0, 2.2.6 Mar 4, 2014

ralphschindler added a commit that referenced this pull request Mar 7, 2014

Merge #5853
Merge branch 'fix/db_rowcounter' of git://github.com/samsonasik/zf2 into feature/5853-adapter-row-counter-partial-fix

* 'fix/db_rowcounter' of git://github.com/samsonasik/zf2:
  added tests for getCountForStatement, getCountForSql, getRowCountClosure
  fix namespace and add test for getCountForStatement
  Fixes #4943

ralphschindler added a commit that referenced this pull request Mar 7, 2014

Closes #5853, #4943
Merge branch 'feature/5853-adapter-row-counter-partial-fix' into develop

* feature/5853-adapter-row-counter-partial-fix:
  Zend\Db\Adapter\Pdo added unit tests to row counter fix
  added tests for getCountForStatement, getCountForSql, getRowCountClosure
  fix namespace and add test for getCountForStatement
  Fixes #4943
Member

ralphschindler commented Mar 7, 2014

Merged to develop

samsonasik added a commit to samsonasik/zf2 that referenced this pull request Mar 7, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment