Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Update NotEmptyTest tests to use data providers where possible #5879

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Rather than making a dozen or so assertions in a test, converting to @dataProvider tests means we will know each value that fails for each test.

I refactored the tests for the NotEmpty validator to use dataproviders which means it should now show 245 tests with 253 assertions compared to 28 tests with 248 assertions previously.

Additionally, I removed the two test classes that were defined at the end of this file and replaced them with PHPUnit mock objects in the tests where they were being used.

@weierophinney weierophinney added this to the 2.2.6 milestone Mar 3, 2014

@Ocramius Ocramius added the Validator label Mar 4, 2014

@Ocramius Ocramius self-assigned this Mar 4, 2014

@Ocramius Ocramius added the enhancement label Mar 4, 2014

@Ocramius Ocramius closed this in fbe0a0a Mar 4, 2014

Ocramius added a commit that referenced this pull request Mar 4, 2014

Member

Ocramius commented Mar 4, 2014

@dstockto thanks! Awesome!

@dstockto dstockto deleted the dstockto:notEmptyDataProviderTests branch Mar 4, 2014

gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

gianarb pushed a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment