Added testcase for BlockCipher using 0 values #5902

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

auterium commented Mar 3, 2014

Tested against 0 (integer), 0.0 (float), and '0' (string). All 3 values should be accepted

Added testcase
Tested against 0 (integer), 0.0 (float), and '0' (string). All 3 values should be accepted
Contributor

auterium commented Mar 3, 2014

@Maks3w here's the test case for zendframework#5680

@@ -149,6 +149,23 @@ public function testEncryptDecryptUsingBinary()
}
}
+ public function testEncryptDecryptUsingZero()
+ {
+ $possibleValues = array(0, 0.0, '0');
@Maks3w

Maks3w Mar 3, 2014

Member

Please refactor this for use a data provider

@Maks3w Maks3w added this to the 2.2.6 milestone Mar 6, 2014

@weierophinney weierophinney modified the milestones: 2.3.0, 2.2.6 Mar 7, 2014

weierophinney added a commit that referenced this pull request Mar 10, 2014

Merge pull request #5902 from auterium/patch-1
Added testcase for BlockCipher using 0 values

weierophinney added a commit that referenced this pull request Mar 10, 2014

[#5902] Implement fix for issue demonstrated in test
- Changed test to use a data provider
- Implemented a fix for the behavior demonstrated by the test

weierophinney added a commit that referenced this pull request Mar 10, 2014

Owner

weierophinney commented Mar 10, 2014

Merged to master with updates to the library that address the issue demonstrated in the tests.

weierophinney added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015

Merge pull request zendframework/zendframework#5902 from auterium/pat…
…ch-1

Added testcase for BlockCipher using 0 values

weierophinney added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015

[zendframework/zendframework#5902] Implement fix for issue demonstrat…
…ed in test

- Changed test to use a data provider
- Implemented a fix for the behavior demonstrated by the test

weierophinney added a commit to zendframework/zend-crypt that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment