Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

minor improvements to form labels #5910

Merged
merged 4 commits into from Mar 5, 2014

Conversation

Projects
None yet
3 participants
Contributor

stefanotorresi commented Mar 5, 2014

the LabelOptionsAwareInterface was introduced in #4677 to preserve BC with 5.3.3, but since the whole functionality will make into 2.3 release and we're upping the minimum PHP version, some cleaning is due.

also minor cleanup subsequent to #5533 and reinstated #5539 new feature

it is important to merge this along with #4677 (which hasn't made yet into any release) before 2.3, otherwise this would become a bc break for the very PR it's trying to clean up. ;)

stefanotorresi added some commits Mar 5, 2014

LabelOptionsAwareInterface => LabelAwareInterface
this should not be a BC break because the interface is not included in
any release yet, change only affect develop branch

@Ocramius Ocramius and 1 other commented on an outdated diff Mar 5, 2014

library/Zend/Form/LabelAwareTrait.php
@@ -9,7 +9,7 @@
namespace Zend\Form;
-class LabelOptionsAwareTrait
+class LabelAwareTrait
@Ocramius

Ocramius Mar 5, 2014

Member

Confused... not a trait?

@stefanotorresi

stefanotorresi Mar 5, 2014

Contributor

oops! typo :P

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 5, 2014

@weierophinney weierophinney self-assigned this Mar 5, 2014

weierophinney added a commit that referenced this pull request Mar 5, 2014

weierophinney added a commit that referenced this pull request Mar 5, 2014

@weierophinney weierophinney merged commit 6fde51b into zendframework:develop Mar 5, 2014

1 check failed

default The Travis CI build failed
Details

@stefanotorresi stefanotorresi deleted the stefanotorresi:improvement/form-labels branch Mar 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment