Hotfix/4785 csrf name conflicts #5918

Closed
wants to merge 12 commits into
from

2 participants

@stefanotorresi

this PR should fix #4785

I'm not very sure about it, it is probably not very fancy, but I should have managed to fix the validator without adding any further state to it, actually even removing some, and maintain BC.

As far as I can tell, the only downside is that tokens are not statically cached any more and are regenerated each time a new validator instance is created (which may arguably be an improvement).

I had to edit ZendTest\Form\FormElementManagerFactoryTest because it was a bit of a mess. I didn't delve too much into it, but further cleaning is possible. I honestly don't know how much of a test I can change for this purpose. Also, it is failing in php 5.3.3 only, no clue why. I suppose it's not a problem since this issue was tagged for milestone 2.3.0.

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 7, 2014
@weierophinney weierophinney self-assigned this Mar 7, 2014
@weierophinney
Zend Framework member

Yeah, not worried about the 5.3.3 test failures at all. Merging to develop for release with 2.3.0.

@weierophinney weierophinney added a commit that referenced this pull request Mar 7, 2014
@weierophinney weierophinney Merge branch 'hotfix/5918' into develop
Close #5918
Fixes #4785
9969cb4
@stefanotorresi stefanotorresi deleted the stefanotorresi:hotfix/4785-csrf-name-conflicts branch Mar 7, 2014
@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge pull request zendframework/zendframework#5918 from stefanotorre…
…si/hotfix/4785-csrf-name-conflicts

Hotfix/4785 csrf name conflicts
90fff74
@weierophinney weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015
@weierophinney weierophinney Merge branch 'hotfix/5918' into develop da00a68
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment