Update DateStep.php #5925

Merged
merged 2 commits into from Mar 7, 2014

Conversation

Projects
None yet
3 participants
Contributor

maxnuf commented Mar 6, 2014

fix error: Undefined class constant 'FALSE_FORMAT'
add missing template messages

Update DateStep.php
fix error: Undefined class constant 'FALSE_FORMAT'
@@ -174,7 +174,7 @@ protected function convertString($value, $addErrors = true)
$errors = DateTime::getLastErrors();
if ($errors['warning_count'] > 0) {
if ($addErrors) {
- $this->error(self::FALSE_FORMAT);
+ $this->error(self::FALSEFORMAT);
@Ocramius

Ocramius Mar 6, 2014

Member

It doesn't seem clear from the diffs, but is there a hidden character here (between FALSE and FORMAT)?

@weierophinney

weierophinney Mar 6, 2014

Owner

Not seeing any problem myself, @Ocramius -- maybe an issue with how the diff HTML markup is generated? The diff does not show a space: https://github.com/zendframework/zf2/pull/5925.diff

@Ocramius

Ocramius Mar 6, 2014

Member

Nvm... something weird with firefox nightly and the generated HTML

@weierophinney weierophinney added this to the 2.3.0 milestone Mar 6, 2014

add missing message templates
DateStep extends Date and calls parent::isValid
it must implement the same messageTemplates

@weierophinney weierophinney self-assigned this Mar 7, 2014

weierophinney added a commit that referenced this pull request Mar 7, 2014

weierophinney added a commit that referenced this pull request Mar 7, 2014

@weierophinney weierophinney merged commit 6702d46 into zendframework:develop Mar 7, 2014

1 check failed

default The Travis CI build failed
Details

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

weierophinney added a commit to zendframework/zend-validator that referenced this pull request May 15, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment