Fix for issue #4267 #5936

Closed
wants to merge 5 commits into
from

Conversation

Projects
None yet
4 participants
Contributor

god107 commented Mar 8, 2014

No description provided.

@samsonasik samsonasik commented on an outdated diff Mar 8, 2014

tests/ZendTest/Feed/Reader/ReaderTest.php
@@ -302,6 +302,12 @@ public function testImportRemoteFeedMethodPerformsAsExpected()
$this->assertEquals(Reader\Reader::TYPE_RSS_20, $type);
}
+ public function testImportStringMethodThrowProperExceptionOnEmptyString(){
Contributor

god107 commented Mar 8, 2014

Ok, I thought that cs fixer is doing that in pre-commit hook.

I don't know why Tests are failed.

Contributor

god107 commented Mar 8, 2014

Ok, now it should be correct. Test on my pc passed after first commits but i'm using newer version of PHP. Don't even know before that empty() accepts only variables nor returned values by function prior to PHP 5.5.

Contributor

ThaDafinser commented Mar 10, 2014

@god107 looking sadly at travis there was a timeout...
Maye enhance the test even further and test for is_string()
And display the message: "Only non empty strings are allowed as input"

Contributor

god107 commented Mar 10, 2014

ok, i'll fix this but i have question: What about that Travis show timeout for connecting to github:

The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed. Retrying, 3 of 3.
Cloning into 'zendframework/zf2'...
fatal: unable to connect to github.com:
github.com: Temporary failure in name resolution
The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed and exited with 128 during checkout.
Contributor

samsonasik commented Mar 10, 2014

it's travis issue I think ;). I think you should no worry about that :D. It
usually fixed with next commit / squash the commit :D

Warm Regards,

Abdul Malik Ikhsan

2014-03-10 16:12 GMT+07:00 Marcin Twardowski notifications@github.com:

ok, i'll fix this but i have question: What about that Travis show timeout
for connecting to github:

The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed. Retrying, 3 of 3.
Cloning into 'zendframework/zf2'...
fatal: unable to connect to github.com:github.com: Temporary failure in name resolution
The command "git clone --depth=50 git://github.com/zendframework/zf2.git zendframework/zf2" failed and exited with 128 during checkout.

Reply to this email directly or view it on GitHubhttps://github.com/zendframework/zf2/pull/5936#issuecomment-37163747
.

Contributor

god107 commented Mar 10, 2014

Strange, now i'm seeing that test in ZendTest/Cache failed but i did'n touch there anything. :/

Contributor

samsonasik commented Mar 10, 2014

Don't worry about that ;)

Warm regards,

Abdul Malik Ikhsan

Pada 10 Mar 2014, pukul 16.54, Marcin Twardowski notifications@github.com menulis:

Strange, now i'm seeing that test in ZendTest/Cache failed but i did'n touch there anything. :/


Reply to this email directly or view it on GitHub.

weierophinney added this to the 2.3.0 milestone Mar 10, 2014

weierophinney self-assigned this Mar 10, 2014

@weierophinney weierophinney added a commit that referenced this pull request Mar 10, 2014

@weierophinney weierophinney Merge pull request #5936 from god107/zf4267
Fix for issue #4267
69e1333

@weierophinney weierophinney added a commit that referenced this pull request Mar 10, 2014

@weierophinney weierophinney Merge branch 'hotfix/5936' into develop
Close #5936
Fixes #4267
7b1e202
Owner

weierophinney commented Mar 10, 2014

Merged to develop for release with 2.3.0.

god107 deleted the unknown repository branch Mar 11, 2014

@weierophinney weierophinney added a commit to zendframework/zend-feed that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#5936 from god107/zf4267 67da72f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment