Fix console mixed case optional value params #5951

Merged
merged 2 commits into from Mar 11, 2014

Conversation

Projects
None yet
2 participants
Member

Thinkscape commented Mar 11, 2014

This one slipped through.

When using optional value params in console routes, i.e.

do something [<withThisData>]

Given the following script invocation:

./zf2 do something "with foo"

We would receive the following route match:

// actual
[
  'withthisdata' => 'with foo'
]

Where it should be:

// expected
[
  'withThisData' => 'with foo'
]

Notice that withThisData parameter became lowercased withthisdata.

@weierophinney - we need to include a note on that in release notes, in case someone just ignored the bug and consumed all-lowercased parameter names.

@weierophinney weierophinney added a commit that referenced this pull request Mar 11, 2014

@weierophinney weierophinney Merge branch 'hotfix/5951' into develop
Close #5951
e6ecdf9

weierophinney merged commit e282acb into zendframework:develop Mar 11, 2014

1 check passed

default The Travis CI build passed
Details

@weierophinney weierophinney modified the milestone: 2.3.1, 2.3.0 Mar 11, 2014

weierophinney self-assigned this Mar 11, 2014

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge pull request zendframework/zendframework#5951 from Thinkscape/h…
…otfix/console-mixed-case-optional-value-params

Fix console mixed case optional value params
f883f27

@weierophinney weierophinney added a commit to zendframework/zend-console that referenced this pull request May 15, 2015

@weierophinney weierophinney Merge branch 'hotfix/5951' into develop b5b78a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment